Issue 419773003: gs_utils.upload_file(): upload with temp name, verify contents, then rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419773003: gs_utils.upload_file(): upload with temp name, verify contents, then rename (Closed)

Created:
6 years, 5 months ago by epoger

Modified:
6 years, 5 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/common.git@master

Visibility:
Public.

gs_utils.upload_file(): upload with temp name, verify contents, then rename I want to do this before we start uploading multiple files in parallel, so we will be protected against any failures. BUG=skia:2780 R=borenet@google.com Committed: https://skia.googlesource.com/common/+/ff9e4d8

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -14 lines)			Patch
	M	py/utils/gs_utils.py	View	1	6 chunks	+49 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

epoger

6 years, 5 months ago (2014-07-25 18:52:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as rff9e4d8 (presubmit successful).