base/synchronization/waitable_event_posix.cc - Issue 419773002: Take extra lock in base::WaitableEvent::WaitMany.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_posix.cc

Issue 419773002: Take extra lock in base::WaitableEvent::WaitMany. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/synchronization/waitable_event_posix.cc

diff --git a/base/synchronization/waitable_event_posix.cc b/base/synchronization/waitable_event_posix.cc

index fccba9d31c67c767b0b8172e10ad127ab2a5cb24..2203af482ed5d7c7dd199c93e2e1e89323871102 100644

--- a/base/synchronization/waitable_event_posix.cc

+++ b/base/synchronization/waitable_event_posix.cc

@@ -42,6 +42,8 @@ WaitableEvent::WaitableEvent(bool manual_reset, bool initially_signaled)

}

WaitableEvent::~WaitableEvent() {

+ // TODO(yhirano): Write comment here

yhirano 2014/07/31 11:48:20 I will add a comment tomorrow...

+ base::AutoLock locked(kernel_->lock_);

}

void WaitableEvent::Reset() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »