ui/gfx/render_text_harfbuzz.cc - Issue 419753002: Prepare to enable RenderTextHarfBuzz by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 419753002: Prepare to enable RenderTextHarfBuzz by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable/disable flags Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index 2fcf15711ff551377b09f42c903f9688eac29a5c..2977355991e3d443f3766066b7317981bcb588f0 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -632,6 +632,7 @@ SelectionModel RenderTextHarfBuzz::AdjacentWordSelectionModel(

}

Range RenderTextHarfBuzz::GetGlyphBounds(size_t index) {

msw 2014/07/26 02:54:14 nit: reorder this definition to match its declarat

ckocagil 2014/07/26 03:55:59 Done.

+ EnsureLayout();

const size_t run_index =

GetRunContainingCaret(SelectionModel(index, CURSOR_FORWARD));

// Return edge bounds if the index is invalid or beyond the layout text size.

« no previous file with comments | « ui/gfx/render_text_harfbuzz.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »