reviving xiang's cl as a stopgap for the memcache + serviceworker interop problem

Bust the MemoryCache to ensure script requests reach the browser-side and get added to and retrieved from the ServiceWorker's script cache.

BUG=387589
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179868

[michaeln, 2014-07-25 01:13:11]

running this thru the trybots, resolves the bug in local testing, i think we
should do this in m38 to mitigate the memcache interop problem

wdyt?

[michaeln, 2014-07-25 20:21:38]

ping!

[dominicc (has gone to gerrit), 2014-07-26 22:37:20]

On 2014/07/25 20:21:38, michaeln wrote:
> ping!

I can haz test?

[michaeln1, 2014-07-28 22:08:47]

> I can haz test?

yea, i think a layout test that does reg/unreg/re-reg in sequence with a sw that
performs an import would do it

[michaeln, 2014-07-31 03:12:08]

i have a browser_test for this
https://codereview.chromium.org/434453005/

[dominicc (has gone to gerrit), 2014-08-04 01:13:48]

More comments.

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:129: // FIXME: Bust
thru the memorycache until the it and serviceworkers are better integrated.
Be more specific than "better integrated"

It might be nice to briefly explain the purpose: to ensure script requests reach
the browser-side Service Worker script cache.

Avoid mispellings like "thru"

Capitalize nouns like Service Workers

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/ServiceWorkerGlobalScope.h (right):

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.h:1: /*
Can you change the CL description to capitalize Service Worker and so on? It
looks a little stream-of-consciousness.

I also think you want this reviewed and not to TBR Xiang, who is not an OWNER
yet.

[michaeln, 2014-08-08 02:58:39]

ptal, also at the revised test case (https://codereview.chromium.org/434453005/)

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/419693002/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:129: // FIXME: Bust
thru the memorycache until the it and serviceworkers are better integrated.
On 2014/08/04 01:13:48, dominicc wrote:
> Be more specific than "better integrated"
> 
> It might be nice to briefly explain the purpose: to ensure script requests
reach
> the browser-side Service Worker script cache.
> 
> Avoid mispellings like "thru"
> 
> Capitalize nouns like Service Workers

Done.

[dominicc (has gone to gerrit), 2014-08-08 05:27:57]

LGTM modulo some comment nits.

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:184: // and get added
to and retrieved from the ServiceWorker's script cache.
I think the "and retrieved from" is a bit inaccurate? The point is primarily
that they're added to that cache.

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:185: // FIXME:
Revisit in light of the solution to crbug/388375.
I don't think you need this FIXME; I think CR388375 should be specifically about
not sharing between Service Workers/scopes/something in the memory cache.

[michaeln, 2014-08-08 19:51:43]

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right):

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:184: // and get added
to and retrieved from the ServiceWorker's script cache.
On 2014/08/08 05:27:57, dominicc wrote:
> I think the "and retrieved from" is a bit inaccurate? The point is primarily
> that they're added to that cache.

i think it's accurate, maybe less obvious. once the correct resource is cached,
it also has to be utilized for subsequent starts of the worker. one w/o the
other does not solve the problem of using the right script.

https://codereview.chromium.org/419693002/diff/20001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:185: // FIXME:
Revisit in light of the solution to crbug/388375.
On 2014/08/08 05:27:57, dominicc wrote:
> I don't think you need this FIXME; I think CR388375 should be specifically
about
> not sharing between Service Workers/scopes/something in the memory cache.

I don't want to leave the impression that this is a complete fix for this
problem because i don't this it is. It's a bit of a hack and as coded the wrong
resource could still be picked up albeit the window of opportunity is pretty
small. This is related to 388375 in that the resource that should be returned is
dependent on the context asking for it. The comment just says should be
revisited in light of what is done on behalf of CR388375.

[michaeln, 2014-08-08 19:52:15]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:53:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaeln@chromium.org/419693002/20001

[commit-bot: I haz the power, 2014-08-08 21:17:43]

Change committed as 179868