Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: components/rappor/bloom_filter_unittest.cc

Issue 419683014: Randomly select a single rappor sample when more than one is collected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/rappor/bloom_filter.cc ('k') | components/rappor/rappor_metric.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/rappor/bloom_filter_unittest.cc
diff --git a/components/rappor/bloom_filter_unittest.cc b/components/rappor/bloom_filter_unittest.cc
index 9a64e25924f5972a9766de8a780100ce2db5021e..25f965f8402835ea354ea5f5f391a839baa9d456 100644
--- a/components/rappor/bloom_filter_unittest.cc
+++ b/components/rappor/bloom_filter_unittest.cc
@@ -17,21 +17,21 @@ TEST(BloomFilterTest, TinyFilter) {
EXPECT_EQ(0x00, filter.bytes()[0]);
// "Test" has a self-collision, and only sets 3 bits.
- filter.AddString("Test");
+ filter.SetString("Test");
EXPECT_EQ(0x2a, filter.bytes()[0]);
- // Adding the same value shouldn't change anything.
- filter.AddString("Test");
+ // Setting the same value shouldn't change anything.
+ filter.SetString("Test");
EXPECT_EQ(0x2a, filter.bytes()[0]);
BloomFilter filter2(1u, 4u, 0u);
EXPECT_EQ(0x00, filter2.bytes()[0]);
- filter2.AddString("Bar");
+ filter2.SetString("Bar");
EXPECT_EQ(0xa8, filter2.bytes()[0]);
- // Adding a colliding string should just set new bits.
- filter.AddString("Bar");
- EXPECT_EQ(0xaa, filter.bytes()[0]);
+ // The new string should replace the old one.
+ filter.SetString("Bar");
+ EXPECT_EQ(0xa8, filter.bytes()[0]);
}
TEST(BloomFilterTest, HugeFilter) {
@@ -43,11 +43,11 @@ TEST(BloomFilterTest, HugeFilter) {
EXPECT_EQ(500u, filter.bytes().size());
EXPECT_EQ(0, CountBits(filter.bytes()));
- filter.AddString("Bar");
+ filter.SetString("Bar");
EXPECT_EQ(1, CountBits(filter.bytes()));
// Adding the same value shouldn't change anything.
- filter.AddString("Bar");
+ filter.SetString("Bar");
EXPECT_EQ(1, CountBits(filter.bytes()));
}
« no previous file with comments | « components/rappor/bloom_filter.cc ('k') | components/rappor/rappor_metric.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698