chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 419683008: mac: Toolbar renders incorrectly when downloads bar is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 419683008: mac: Toolbar renders incorrectly when downloads bar is open. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from shess, round two. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index 9b0aa210628307705ed0bfa2d7b37c8b9ea7bd82..6a6a4f0bea3565b562db7358d194b799c001ab11 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -185,6 +185,14 @@ willPositionSheet:(NSWindow*)sheet

NSWindow* window = [self window];

NSView* contentView = [window contentView];

NSRect contentBounds = [contentView bounds];

+ // Lay out the chromeContentView.

+ NSView* chromeContentView = [self chromeContentView];

+ BOOL autoresizesSubviews = [chromeContentView autoresizesSubviews];

+ [chromeContentView setAutoresizesSubviews:NO];

+ [chromeContentView setFrame:contentBounds];

+ [chromeContentView setAutoresizesSubviews:autoresizesSubviews];

CGFloat minX = NSMinX(contentBounds);

CGFloat minY = NSMinY(contentBounds);

CGFloat width = NSWidth(contentBounds);

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »