Issue 419683006: Revert of mojo: fix little bug in DynamicServiceLoader/Runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419683006: Revert of mojo: fix little bug in DynamicServiceLoader/Runner (Closed)

Created:
6 years, 5 months ago by Mark P

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review), tim (not reviewing)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of mojo: fix little bug in DynamicServiceLoader/Runner (https://codereview.chromium.org/414173004/) Reason for revert: One of the test this adds fails on linux clang bog: http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62568 Original issue's description: > mojo: fix little bug in DynamicServiceLoader/Runner > > If the Runner wasn't actually told to Start(), the DelegateSimpleThread would > DCHECK for not having been Started. This patch makes it so we don't allocate > a DST unless we need to. > > Also adds basic unittest files for DynamicServiceLoader and Runner. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285650 TBR=darin@chromium.org,tim@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285673

Patch Set 1 #

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -113 lines)			Patch
M	mojo/mojo.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/shell/dynamic_service_loader.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
D	mojo/shell/dynamic_service_loader_unittest.cc	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	mojo/shell/in_process_dynamic_service_runner.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/shell/in_process_dynamic_service_runner.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
D	mojo/shell/in_process_dynamic_service_runner_unittest.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark P

Created Revert of mojo: fix little bug in DynamicServiceLoader/Runner

6 years, 5 months ago (2014-07-25 20:37:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/419683006/1

6 years, 5 months ago (2014-07-25 20:42:56 UTC) #2

Message was sent while issue was closed.

Change committed as 285673

Expand Messages | Collapse Messages