Issue 419683004: In GrowMode, force the value to the right representation to avoid deopts between storing the length…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419683004: In GrowMode, force the value to the right representation to avoid deopts between storing the length… (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

In GrowMode, force the value to the right representation to avoid deopts between storing the length and storing the value. BUG=16459193 LOG=n R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22616

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -18 lines)			Patch
M	src/hydrogen.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+15 lines, -8 lines	0 comments	Download
A +	test/mjsunit/regress/regress-grow-deopt.js	View	1 chunk	+7 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

6 years, 5 months ago (2014-07-25 11:48:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22616 (presubmit successful).