Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 419683003: Inject a prototype object of a private script into the prototype chain of a holder object (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Inject a prototype object of a private script into the prototype chain of a holder object This is a split CL from https://codereview.chromium.org/394773003/. This CL lets |this| object use properties defined on a prototype object of the private script. For example: installClass("HTMLMarqueeElement", function(global, HTMLMarqueeElementPrototype) { HTMLMarqueeElementPrototype.foo = function () { ... }; HTMLMarqueeElementPrototype.bar = function () { this.foo(); // This CL makes this workable. }; }); Before this CL, we had to write foo.call(this) because the HTMLMarqueeElementPrototype is not in the prototype chain of |this| object. After this CL, the HTMLMarqueeElementPrototype is in the prototype chain, so we can just write it as this.foo(). BUG=341031 TEST=fast/dom/private_script_unittest.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178918

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/PrivateScriptRunner.js View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.js View 1 2 3 chunks +1 line, -5 lines 0 comments Download
M Source/core/testing/PrivateScriptTest.js View 1 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 5 months ago (2014-07-25 02:51:01 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-25 07:25:36 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 5 months ago (2014-07-25 08:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/419683003/40001
6 years, 5 months ago (2014-07-25 08:02:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:29:48 UTC) #5
Message was sent while issue was closed.
Change committed as 178918

Powered by Google App Engine
This is Rietveld 408576698