Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(912)

Issue 419683002: Revert r38549, r38552, and r38557. (Closed)

Created:
6 years, 1 month ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Revert r38549, r38552, and r38557. It's currently too difficult to include a third party package for it to be worthwhile for this use case. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=38564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -139 lines) Patch
M dart/pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download
D dart/pkg/pool/CHANGELOG.md View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/pkg/pool/lib/pool.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M dart/pkg/pool/pubspec.yaml View 1 chunk +1 line, -2 lines 0 comments Download
M dart/pkg/pool/test/pool_test.dart View 4 chunks +67 lines, -120 lines 0 comments Download
M dart/third_party/pkg/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M deps/all.deps/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 1 month ago (2014-07-25 00:31:24 UTC) #1
Alan Knight
lgtm
6 years, 1 month ago (2014-07-25 00:32:10 UTC) #2
nweiz
6 years, 1 month ago (2014-07-25 00:32:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698