LayoutTests/http/tests/media/media-source/mediasource-buffered.html - Issue 419673007: Adding more MSE tests.

Side by Side Diff: LayoutTests/http/tests/media/media-source/mediasource-buffered.html

Issue 419673007: Adding more MSE tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing debug messages Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html ('K') | « LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html ('k') | LayoutTests/http/tests/media/media-source/mediasource-buffered-expected.txt » ('j') | LayoutTests/http/tests/media/media-source/mediasource-closed.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/w3c/resources/testharness.js"></script>	4 <script src="/w3c/resources/testharness.js"></script>

5 <script src="/w3c/resources/testharnessreport.js"></script>	5 <script src="/w3c/resources/testharnessreport.js"></script>

6 <script src="mediasource-util.js"></script>	6 <script src="mediasource-util.js"></script>

7 <link rel="stylesheet" href="/w3c/resources/testharness.css">	7 <link rel="stylesheet" href="/w3c/resources/testharness.css">

8 </head>	8 </head>

9 <body>	9 <body>

10 <div id="log"></div>	10 <div id="log"></div>

(...skipping 176 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
187 test.expectEvent(sourceBuffer, "updateend", "initSegment append ended.");	187 test.expectEvent(sourceBuffer, "updateend", "initSegment append ended.");

188 sourceBuffer.appendBuffer(initSegment);	188 sourceBuffer.appendBuffer(initSegment);

189 test.waitForExpectedEvents(function()	189 test.waitForExpectedEvents(function()

190 {	190 {

191 assertBufferedEquals(mediaSource.sourceBuffers[0], "{ }", "m ediaSource.sourceBuffers[0]");	191 assertBufferedEquals(mediaSource.sourceBuffers[0], "{ }", "m ediaSource.sourceBuffers[0]");

192 assertBufferedEquals(mediaSource.activeSourceBuffers[0], "{ }", "mediaSource.activeSourceBuffers[0]");	192 assertBufferedEquals(mediaSource.activeSourceBuffers[0], "{ }", "mediaSource.activeSourceBuffers[0]");

193 assertBufferedEquals(mediaElement, "{ }", "mediaElement.buff ered");	193 assertBufferedEquals(mediaElement, "{ }", "mediaElement.buff ered");

194 test.done();	194 test.done();

195 });	195 });

196	196

197 }, "Get buffered range when only initsegment is appended.");	197 }, "Get buffered range when only initsegment is appended.");
	wolenetz 2014/07/26 00:07:15 nit: is there extra trailing whitespace here? if s nit: is there extra trailing whitespace here? if so, please remove. prabhur1 2014/07/28 21:36:49 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > nit: is there extra trailing whitespace here? if so, please remove. Done.
	198

	199 mediasource_testafterdataloaded(function(test, mediaElement, mediaSo urce, segmentInfo, sourceBuffer, mediaData)

	200 {

	201 test.expectEvent(mediaSource.activeSourceBuffers, "removesourceb uffer", "SourceBuffer removed.");
	wolenetz 2014/07/26 00:07:15 ditto: sourceBuffer really shouldn't be in activeS ditto: sourceBuffer really shouldn't be in activeSourceBuffers until init segment received algo runs on a valid init segment that makes the sourceBuffer active. s/active// here and add another test that first appends an init segment and verifies removal from activeSourceBuffers. prabhur1 2014/07/28 21:36:49 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > ditto: sourceBuffer really shouldn't be in activeSourceBuffers until init > segment received algo runs on a valid init segment that makes the sourceBuffer > active. s/active// here and add another test that first appends an init segment > and verifies removal from activeSourceBuffers. Done.
	202 mediaSource.removeSourceBuffer(sourceBuffer);

	203

	204 test.waitForExpectedEvents(function()

	205 {

	206 assert_throws("InvalidStateError",

	207 function() { sourceBuffer.buffered; },

	208 "get sourceBuffer.buffered throws an exception for Inval idStateError.");

	209
	wolenetz 2014/07/26 00:07:15 nit: remove blank line. nit: remove blank line. prabhur1 2014/07/28 21:36:49 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > nit: remove blank line. Done.
	210 test.done();

	211 });

	212
	wolenetz 2014/07/26 00:07:15 nit: remove blank line. nit: remove blank line. prabhur1 2014/07/28 21:36:49 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > nit: remove blank line. Done.
	213 }, "Get buffered range after removing sourcebuffer.");
	wolenetz 2014/07/26 00:07:15 ditto: eek! " vs ' inconsistencies. prefer ' :) ditto: eek! " vs ' inconsistencies. prefer ' :) prabhur1 2014/07/28 21:36:49 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > ditto: eek! " vs ' inconsistencies. prefer ' :) Done.
198 </script>	214 </script>

199 </body>	215 </body>

200 </html>	216 </html>

OLD	NEW