LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html - Issue 419673007: Adding more MSE tests.

Side by Side Diff: LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html

Issue 419673007: Adding more MSE tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing debug messages Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/media/media-source/mediasource-append-buffer.html ('K') | « LayoutTests/http/tests/media/media-source/mediasource-append-buffer-expected.txt ('k') | LayoutTests/http/tests/media/media-source/mediasource-buffered.html » ('j') | LayoutTests/http/tests/media/media-source/mediasource-buffered.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/w3c/resources/testharness.js"></script>	4 <script src="/w3c/resources/testharness.js"></script>

5 <script src="/w3c/resources/testharnessreport.js"></script>	5 <script src="/w3c/resources/testharnessreport.js"></script>

6 <script src="mediasource-util.js"></script>	6 <script src="mediasource-util.js"></script>

7 <link rel='stylesheet' href='/w3c/resources/testharness.css'>	7 <link rel='stylesheet' href='/w3c/resources/testharness.css'>

8 </head>	8 </head>

9 <body>	9 <body>

10 <div id="log"></div>	10 <div id="log"></div>

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 assert_throws({name: "TypeError"},	43 assert_throws({name: "TypeError"},

44 function() { sourceBuffer.appendWindowStart = Number.NaN; },	44 function() { sourceBuffer.appendWindowStart = Number.NaN; },

45 "set appendWindowStart throws an exception for Number.NaN.");	45 "set appendWindowStart throws an exception for Number.NaN.");

46	46

47 assert_throws("InvalidAccessError",	47 assert_throws("InvalidAccessError",

48 function() { sourceBuffer.appendWindowStart = 600.0; },	48 function() { sourceBuffer.appendWindowStart = 600.0; },

49 "set appendWindowStart throws an exception when greater than a ppendWindowEnd.");	49 "set appendWindowStart throws an exception when greater than a ppendWindowEnd.");

50	50

51 assert_throws("InvalidAccessError",	51 assert_throws("InvalidAccessError",

52 function() { sourceBuffer.appendWindowStart = sourceBuffer.app endWindowEnd; },	52 function() { sourceBuffer.appendWindowStart = sourceBuffer.app endWindowEnd; },

53 "set appendWindowStart throws an exception when equal to appen dWindowEnd.");	53 "set appendWindowStart throws an exception when equal to appen dWindowEnd.");
	wolenetz 2014/07/26 00:07:15 I see in our tracking spreadsheet that "set append I see in our tracking spreadsheet that "set appendWindowEnd value equal to appendWindowStart" is "NewAdded" as of Jul 21, but I see no corresponding test. Note that there is distinct code executed by setting appendWindowStart vs setting appendWindowEnd attribute, so this specific assert_throws() doesn't exactly cover verification of both attribute's setter logic for this case. Please add another assert_throws() to really cover the "NewAdded" described above. prabhur1 2014/07/28 21:36:48 Done. Show quoted text On 2014/07/26 00:07:15, wolenetz wrote: > I see in our tracking spreadsheet that "set appendWindowEnd value equal to > appendWindowStart" is "NewAdded" as of Jul 21, but I see no corresponding test. > Note that there is distinct code executed by setting appendWindowStart vs > setting appendWindowEnd attribute, so this specific assert_throws() doesn't > exactly cover verification of both attribute's setter logic for this case. > Please add another assert_throws() to really cover the "NewAdded" described > above. Done. prabhur1 2014/07/28 21:36:49 ah..got it! On 2014/07/26 00:07:15, wolenetz wrote ah..got it! On 2014/07/26 00:07:15, wolenetz wrote: Show quoted text > I see in our tracking spreadsheet that "set appendWindowEnd value equal to > appendWindowStart" is "NewAdded" as of Jul 21, but I see no corresponding test. > Note that there is distinct code executed by setting appendWindowStart vs > setting appendWindowEnd attribute, so this specific assert_throws() doesn't > exactly cover verification of both attribute's setter logic for this case. > Please add another assert_throws() to really cover the "NewAdded" described > above.
54	54

55 assert_throws("InvalidAccessError",	55 assert_throws("InvalidAccessError",

	56 function() { sourceBuffer.appendWindowEnd = sourceBuffer.appen dWindowStart - 1; },

	57 "set appendWindowEnd throws an exception if less than appendWi ndowStart.");

	58

	59 assert_throws("InvalidAccessError",

56 function() { sourceBuffer.appendWindowStart = -100.0; },	60 function() { sourceBuffer.appendWindowStart = -100.0; },

57 "set appendWindowStart throws an exception when less than 0.") ;	61 "set appendWindowStart throws an exception when less than 0.") ;

58	62

59 assert_throws("InvalidAccessError",	63 assert_throws("InvalidAccessError",

	64 function() { sourceBuffer.appendWindowEnd = -100.0; },

	65 "set appendWindowEnd throws an exception when less than 0.");

	66

	67 assert_throws("InvalidAccessError",

60 function() { sourceBuffer.appendWindowEnd = Number.NaN; },	68 function() { sourceBuffer.appendWindowEnd = Number.NaN; },

61 "set appendWindowEnd throws an exception if NaN.");	69 "set appendWindowEnd throws an exception if NaN.");

62	70

63 assert_throws("InvalidAccessError",	71 assert_throws("InvalidAccessError",

64 function() { sourceBuffer.appendWindowEnd = undefined; },	72 function() { sourceBuffer.appendWindowEnd = undefined; },

65 "set appendWindowEnd throws an exception if undefined.");	73 "set appendWindowEnd throws an exception if undefined.");

66	74

67 assert_throws({name: "TypeError"},	75 assert_throws({name: "TypeError"},

68 function() { sourceBuffer.appendWindowStart = undefined; },	76 function() { sourceBuffer.appendWindowStart = undefined; },

69 "set appendWindowStart throws an exception if undefined.");	77 "set appendWindowStart throws an exception if undefined.");

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
157 "appendWindowStart is POSITIVE_INFINITY initially");	165 "appendWindowStart is POSITIVE_INFINITY initially");

158 test.waitForExpectedEvents(function()	166 test.waitForExpectedEvents(function()

159 {	167 {

160 test.done();	168 test.done();

161 });	169 });

162 }, "Test read appendWindowStart and appendWindowEnd initial values.");	170 }, "Test read appendWindowStart and appendWindowEnd initial values.");

163	171

164 </script>	172 </script>

165 </body>	173 </body>

166 </html>	174 </html>

OLD	NEW