Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 419673005: Revert of Support proper retrying of telemetry_unittests in recipes (Closed)

Created:
6 years, 5 months ago by dmichael (off chromium)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org, dtu, tonyg, ojan, eseidel, jam
Project:
tools
Visibility:
Public.

Description

Revert of Support proper retrying of telemetry_unittests in recipes (https://codereview.chromium.org/417883002/) Reason for revert: Broke telemetry_unittests: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/50387/steps/telemetry_unittests/logs/RecordWprUnitTests Original issue's description: > This patch ports the retry logic we had for mojo_python_tests over to telemetry_unittests and telemetry_perf_unittests, since they are using > the common syntax for retries. > > (I actually refactored the code to be shared in a new PythonBasedTest step class). > > Note that we still don't upload the results to the flakiness dashboard yet, though. Adding that should will be straightforward. > > R=phajdan.jr@chromium.org > BUG=359521 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285595 TBR=phajdan.jr@chromium.org,dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=359521 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -314 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 2 chunks +4 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/steps.py View 2 chunks +86 lines, -65 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_gtest.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json View 1 chunk +1 line, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checklicenses_failure.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checkperms_failure.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_rel_swarming.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_no_bot_update.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_rel_swarming.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_rel_swarming.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_dbg.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_rel.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_no_bot_update.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/mojo_python_tests_failure.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json View 2 chunks +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Created Revert of Support proper retrying of telemetry_unittests in recipes
6 years, 5 months ago (2014-07-25 17:51:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/419673005/1
6 years, 5 months ago (2014-07-25 17:51:44 UTC) #2
commit-bot: I haz the power
Change committed as 285615
6 years, 5 months ago (2014-07-25 17:52:50 UTC) #3
Dirk Pranke
6 years, 5 months ago (2014-07-25 18:29:30 UTC) #4
Message was sent while issue was closed.
On 2014/07/25 17:52:50, I haz the power (commit-bot) wrote:
> Change committed as 285615

lgtm. thanks for the revert! I'll look into the failure.

Powered by Google App Engine
This is Rietveld 408576698