Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 419673003: IDL: Remove UNLIKELY() from constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 419673003: IDL: Remove UNLIKELY() from constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp ('k') | Source/bindings/tests/results/V8TestTypedefs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

index aafb697e692ecb92fead9554432e097f6b387fb2..b9f5f84f33245455dd4f34aa821b98fbeb16d53c 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -98,7 +98,7 @@ static void funcMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- if (UNLIKELY(info.Length() < 1)) {

+ if (info.Length() < 1) {

throwMinimumArityTypeErrorForConstructor("TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

return;

}

@@ -135,7 +135,7 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F

v8SetReturnValue(info, info.Holder());

return;

}

- if (UNLIKELY(info.Length() < 1)) {

+ if (info.Length() < 1) {

throwMinimumArityTypeErrorForConstructor("TestInterfaceWillBeGarbageCollected", 1, info.Length(), info.GetIsolate());

return;

}