Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tools/prepare-bisect-perf-regression.py

Issue 419653002: Style cleanup in auxiliary bisect-related scripts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bisect-manual-test.py ('k') | tools/run-bisect-manual-test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/prepare-bisect-perf-regression.py
diff --git a/tools/prepare-bisect-perf-regression.py b/tools/prepare-bisect-perf-regression.py
index 3c57ce50d08dad01d5a453410ee4ce0e963a117d..9ead957ac13bfc5db9d5d95b1c48940e9b697265 100755
--- a/tools/prepare-bisect-perf-regression.py
+++ b/tools/prepare-bisect-perf-regression.py
@@ -15,7 +15,6 @@ An example usage:
Would result in creating ~/builds/bisect and then populating it with a copy of
the depot.
-
"""
import optparse
@@ -25,6 +24,7 @@ from auto_bisect import bisect_utils
def main():
+ """Does an initial checkout of Chromium then exits."""
usage = ('%prog [options] [-- chromium-options]\n'
'Prepares a temporary depot for use on a trybot.')
@@ -39,7 +39,7 @@ def main():
'working_directory and that will be used to perform the '
'bisection.')
parser.add_option('--output_buildbot_annotations',
- action="store_true",
+ action='store_true',
help='Add extra annotation output for buildbot.')
parser.add_option('--target_platform',
type='choice',
@@ -49,7 +49,7 @@ def main():
'platform), "cros", or "android". If you specify something '
'other than "chromium", you must be properly set up to '
'build that platform.')
- (opts, args) = parser.parse_args()
+ opts, _ = parser.parse_args()
if not opts.working_directory:
print 'Error: missing required parameter: --working_directory'
@@ -59,8 +59,8 @@ def main():
if not bisect_utils.CheckIfBisectDepotExists(opts):
try:
- bisect_utils.CreateBisectDirectoryAndSetupDepot(opts,
- bisect_utils.DEFAULT_GCLIENT_CUSTOM_DEPS)
+ bisect_utils.CreateBisectDirectoryAndSetupDepot(
+ opts, bisect_utils.DEFAULT_GCLIENT_CUSTOM_DEPS)
except RuntimeError:
return 1
return 0
« no previous file with comments | « tools/bisect-manual-test.py ('k') | tools/run-bisect-manual-test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698