Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 419643003: Fix a typo in bindings/scripts/v8_types.py (isoalte -> isolate) (Closed)

Created:
6 years, 5 months ago by zino
Modified:
6 years, 5 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix a typo in bindings/scripts/v8_types.py (isoalte -> isolate) The typo can make some scripting errors. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
zino
PTAL
6 years, 5 months ago (2014-07-25 08:01:38 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-25 08:02:49 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 5 months ago (2014-07-25 08:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/419643003/1
6 years, 5 months ago (2014-07-25 08:04:03 UTC) #4
bashi
Thanks for fixing...
6 years, 5 months ago (2014-07-25 08:11:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-25 09:08:00 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:16:17 UTC) #7
Message was sent while issue was closed.
Change committed as 178916

Powered by Google App Engine
This is Rietveld 408576698