Issue 419613002: Fix GN linking issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419613002: Fix GN linking issues. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, vsevik, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yurys, abarth-chromium, aandrey+blink_chromium.org, Aaron Boodman, paulirish+reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix GN linking issues. This gets rid of most of the non-webrtc/jingle linker errors for webkit_tests. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285375

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -38 lines)			Patch
M	base/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/app/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/devtools/BUILD.gn	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/common/BUILD.gn	View	6 chunks	+9 lines, -13 lines	0 comments	Download
M	content/renderer/BUILD.gn	View	5 chunks	+11 lines, -14 lines	0 comments	Download
M	content/test/BUILD.gn	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	gpu/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/skia_bindings/skia_bindings.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	mojo/bindings/js/BUILD.gn	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/system/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r285375.

Expand Messages | Collapse Messages