Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 419603002: Allow the Chrome Hangouts Test Extension to send feedback. (Closed)

Created:
6 years, 5 months ago by Pete Williamson
Modified:
6 years, 5 months ago
Reviewers:
rkc, Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org, levin
Project:
chromium
Visibility:
Public.

Description

Allow the Chrome Hangouts Test Extension to send feedback. BUG=397242 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285457

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/feedback/js/event_handler.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Pete Williamson
6 years, 5 months ago (2014-07-24 20:37:23 UTC) #1
rkc
lgtm % nit https://codereview.chromium.org/419603002/diff/1/chrome/browser/resources/feedback/js/event_handler.js File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/419603002/diff/1/chrome/browser/resources/feedback/js/event_handler.js#newcode41 chrome/browser/resources/feedback/js/event_handler.js:41: 'knipolnnllmklapflnccelgolnpehhpl', // Chrome Hangouts Extension Nit: ...
6 years, 5 months ago (2014-07-24 20:37:42 UTC) #2
Pete Williamson
The CQ bit was checked by petewil@chromium.org
6 years, 5 months ago (2014-07-24 20:38:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/419603002/1
6 years, 5 months ago (2014-07-24 20:41:35 UTC) #4
Evan Stade
lgtm
6 years, 5 months ago (2014-07-24 21:20:00 UTC) #5
Pete Williamson
Updated comment.
6 years, 5 months ago (2014-07-24 21:22:37 UTC) #6
Pete Williamson
The CQ bit was checked by petewil@chromium.org
6 years, 5 months ago (2014-07-24 21:22:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/419603002/20001
6 years, 5 months ago (2014-07-24 21:26:30 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 02:30:34 UTC) #9
Message was sent while issue was closed.
Change committed as 285457

Powered by Google App Engine
This is Rietveld 408576698