Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 419563003: Adding a word to dictionary should remove spelling markers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased to a newer master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 1b3aa3ed31d52c0d60fd5fcf93ad07499d51043f..f0ac81dafd58b8da78a8df7f0920a3cd4f374625 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3421,6 +3421,19 @@ void WebViewImpl::spellingMarkers(WebVector<uint32_t>* markers)
markers->assign(result);
}
+void WebViewImpl::removeSpellingMarkersUnderWords(const WebVector<WebString>& words)
+{
+ for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+ if (!frame->isLocalFrame())
+ continue;
+
+ Vector<String> convertedWords;
+ convertedWords.append(words.data(), words.size());
please use gerrit instead 2014/08/15 19:08:07 Although the number of frames may be slow, it's be
Klemen Forstnerič 2014/08/16 15:45:50 Done.
+
+ toLocalFrame(frame)->removeSpellingMarkersUnderWords(convertedWords);
+ }
+}
+
WebDragOperation WebViewImpl::dragTargetDragEnterOrOver(const WebPoint& clientPoint, const WebPoint& screenPoint, DragAction dragAction, int keyModifiers)
{
ASSERT(m_currentDragData);

Powered by Google App Engine
This is Rietveld 408576698