Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 419563003: Adding a word to dictionary should remove spelling markers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed my own nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 092bead1c60da397956adfc24db471dd7a533000..7c4d04b6c8da5a7e559528f4161b78cfd83f8956 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -4417,6 +4417,38 @@ TEST_F(WebFrameTest, RemoveSpellingMarkers)
EXPECT_EQ(0U, document->markers().markersInRange(selectionRange.get(), DocumentMarker::Spelling).size());
}
+TEST_F(WebFrameTest, RemoveSpellingMarkersUnderWords)
+{
+ registerMockedHttpURLLoad("spell.html");
+ FrameTestHelpers::WebViewHelper webViewHelper;
+ webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+ SpellCheckClient spellcheck;
+ webViewHelper.webView()->setSpellCheckClient(&spellcheck);
+
+ WebLocalFrameImpl* frame = toWebLocalFrameImpl(webViewHelper.webView()->mainFrame());
+ Document* document = frame->frame()->document();
+ Element* element = document->getElementById("data");
+
+ webViewHelper.webView()->settings()->setAsynchronousSpellCheckingEnabled(true);
+ webViewHelper.webView()->settings()->setUnifiedTextCheckerEnabled(true);
+ webViewHelper.webView()->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
+
+ element->focus();
+ document->execCommand("InsertText", false, " wellcome ");
+
+ WebVector<uint32_t> documentMarkers1;
+ webViewHelper.webView()->spellingMarkers(&documentMarkers1);
+ EXPECT_EQ(1U, documentMarkers1.size());
+
+ WebString word = WebString::fromUTF8("wellcome");
+ WebVector<WebString> words(&word, 1);
+ frame->removeSpellingMarkersUnderWords(words);
+
+ WebVector<uint32_t> documentMarkers2;
+ webViewHelper.webView()->spellingMarkers(&documentMarkers2);
+ EXPECT_EQ(0U, documentMarkers2.size());
+}
+
TEST_F(WebFrameTest, MarkerHashIdentifiers) {
registerMockedHttpURLLoad("spell.html");
FrameTestHelpers::WebViewHelper webViewHelper;

Powered by Google App Engine
This is Rietveld 408576698