Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 419563003: Adding a word to dictionary should remove spelling markers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed my own nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index e6cf59872f4c05426d3870e5c63e2357132f7596..06f1147b7c0d07754ff2752d1c38f3f41402f021 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -1833,6 +1833,14 @@ void WebLocalFrameImpl::willDetachParent()
}
}
+void WebLocalFrameImpl::removeSpellingMarkersUnderWords(const WebVector<WebString>& words)
+{
+ WTF::Vector<String> convertedWords(words.size());
tkent 2014/08/14 01:17:14 |WTF::Vector| should be |Vector|.
Klemen Forstnerič 2014/08/14 16:42:54 Done.
+ std::copy(words.data(), words.data() + words.size(), std::begin(convertedWords));
tkent 2014/08/14 01:17:15 This works and is ok. However, convertedWords
Klemen Forstnerič 2014/08/14 16:42:54 You're right, it seems easier to understand. I've
+
+ frame()->spellChecker().removeSpellingMarkersUnderWords(convertedWords);
+}
+
WebLocalFrameImpl* WebLocalFrameImpl::activeMatchFrame() const
{
ASSERT(!parent());

Powered by Google App Engine
This is Rietveld 408576698