Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 419563003: Adding a word to dictionary should remove spelling markers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 92175fd6a8a5a120555b88b7b169f7b5fecd4e28..f16ddbacfaa0f6aa671722340aa8faf3469cebad 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3381,6 +3381,18 @@ void WebViewImpl::spellingMarkers(WebVector<uint32_t>* markers)
markers->assign(result);
}
+void WebViewImpl::removeSpellingMarkersUnderWords(const WebVector<WebString>& words)
+{
+ for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+ if (!frame->isLocalFrame())
+ continue;
+
+ auto localFrame = static_cast<LocalFrame *>(frame);
dcheng 2014/08/05 20:30:39 We can't use auto in Blink.
Klemen Forstnerič 2014/08/07 17:47:29 Done.
+ auto webLocalFrame = WebLocalFrameImpl::fromFrame(localFrame);
+ webLocalFrame->removeSpellingMarkersUnderWords(words);
+ }
+}
+
WebDragOperation WebViewImpl::dragTargetDragEnterOrOver(const WebPoint& clientPoint, const WebPoint& screenPoint, DragAction dragAction, int keyModifiers)
{
ASSERT(m_currentDragData);

Powered by Google App Engine
This is Rietveld 408576698