Adding a word to dictionary should remove spelling markers

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 3355 matching lines @@
     for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
         if (!frame->isLocalFrame())
             continue;
         const DocumentMarkerVector& documentMarkers = toLocalFrame(frame)->document()->markers().markers();
         for (size_t i = 0; i < documentMarkers.size(); ++i)
             result.append(documentMarkers[i]->hash());
     }
     markers->assign(result);
 }
 
+void WebViewImpl::removeSpellingMarkersUnderWords(const WebVector<WebString>& words)
+{
+    for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+        if (!frame->isLocalFrame())
+            continue;
+
+        LocalFrame* localFrame = static_cast<LocalFrame*>(frame);

[dcheng, 2014/08/14 17:34:28]

Please use toLocalFrame() instead of static_cast<LocalFrame*>.

+        WebLocalFrameImpl* webLocalFrame =
+            WebLocalFrameImpl::fromFrame(localFrame);

[tkent, 2014/08/14 01:17:15]

You don't need to wrap this code.

[Klemen Forstnerič, 2014/08/14 16:42:54]

I don't understand this comment. Could you please clarify it?

[dcheng, 2014/08/14 17:34:28]

I think he means that you can just directly call the LocalFrame function rather
than indirecting through WebLocalFrame.

[tkent, 2014/08/14 22:59:47]

I meant 

    WebLocalFrameImpl* webLocalFrame =
            WebLocalFrameImpl::fromFrame(localFrame);

can be

    WebLocalFrameImpl* webLocalFrame = WebLocalFrameImpl::fromFrame(localFrame);

Blink has no 80 column limit.

+        webLocalFrame->removeSpellingMarkersUnderWords(words);
+    }
+}
+
 WebDragOperation WebViewImpl::dragTargetDragEnterOrOver(const WebPoint& clientPoint, const WebPoint& screenPoint, DragAction dragAction, int keyModifiers)
 {
     ASSERT(m_currentDragData);
 
     m_currentDragData->setModifierKeyState(webInputEventKeyStateToPlatformEventKeyState(keyModifiers));
     DragData dragData(
         m_currentDragData.get(),
         clientPoint,
         screenPoint,
         static_cast<DragOperation>(m_operationsAllowed));
@@ skipping 846 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink