Adding a word to dictionary should remove spelling markers

Source/core/dom/DocumentMarkerController.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 10 matching lines @@
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef DocumentMarkerController_h
 #define DocumentMarkerController_h
 
 #include "core/dom/DocumentMarker.h"
+#include "core/dom/Range.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/heap/Handle.h"
 #include "wtf/HashMap.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
+class MarkerRemoverPredicate {
+public:
+    MarkerRemoverPredicate(Document& document, const Vector<String>& words)
+        : m_document(document), m_words(words)
+    {
+    }
+
+    bool operator()(const DocumentMarker& documentMarker,
+        const Node* node) const {
+

[yosin_UTC9, 2014/08/11 01:01:59]

nit: Please remove an extra blank line.

[Klemen Forstnerič, 2014/08/11 16:24:49]

Done.

+        RefPtr<Range> markerRange = Range::create(m_document,

[yosin_UTC9, 2014/08/11 01:01:59]

Please move implementation of this function to CPP file.
See for explanation:
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in...

[Klemen Forstnerič, 2014/08/11 16:24:49]

Done.

+            const_cast<Node*>(node), documentMarker.startOffset(),
+            const_cast<Node*>(node), documentMarker.endOffset());
+
+        return m_words.contains(markerRange->text())
+            ? true : false;

[yosin_UTC9, 2014/08/11 01:01:59]

nit: We can use implicit |bool| casting, no need to use "?" operator. 

[Klemen Forstnerič, 2014/08/11 16:24:49]

Done.

+    }
+
+private:
+    Document& m_document;
+    Vector<String> m_words;

[yosin_UTC9, 2014/08/11 01:01:59]

Let's use WTF::HashSet<String> rather than WTF::Vector<String>.
Is it better to pass around HashSet from WebFrameImpl?

[Klemen Forstnerič, 2014/08/11 16:24:49]

m_words is likely to be very small, so even though Vector<String>::contains is a
O(n) operation it should be very fast. Could you explain why a
WTF::HashSet<String> would be a better container?

+};
+
 class LayoutPoint;
 class LayoutRect;
 class Node;
-class Range;
 class RenderedDocumentMarker;
 
 class DocumentMarkerController FINAL : public NoBaseWillBeGarbageCollected<DocumentMarkerController> {
     WTF_MAKE_NONCOPYABLE(DocumentMarkerController); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
     DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(DocumentMarkerController);
 public:
 
     DocumentMarkerController();
 
     void clear();
     void addMarker(Range*, DocumentMarker::MarkerType);
     void addMarker(Range*, DocumentMarker::MarkerType, const String& description);
     void addMarker(Range*, DocumentMarker::MarkerType, const String& description, uint32_t hash);
     void addTextMatchMarker(const Range*, bool activeMatch);
 
     void copyMarkers(Node* srcNode, unsigned startOffset, int length, Node* dstNode, int delta);
     bool hasMarkers(Range*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
 
     void prepareForDestruction();
     // When a marker partially overlaps with range, if removePartiallyOverlappingMarkers is true, we completely
     // remove the marker. If the argument is false, we will adjust the span of the marker so that it retains
     // the portion that is outside of the range.
     enum RemovePartiallyOverlappingMarkerOrNot { DoNotRemovePartiallyOverlappingMarker, RemovePartiallyOverlappingMarker };
     void removeMarkers(Range*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers(), RemovePartiallyOverlappingMarkerOrNot = DoNotRemovePartiallyOverlappingMarker);
     void removeMarkers(Node*, unsigned startOffset, int length, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers(),  RemovePartiallyOverlappingMarkerOrNot = DoNotRemovePartiallyOverlappingMarker);
 
     void removeMarkers(DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
     void removeMarkers(Node*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
+    void removeMarkers(const MarkerRemoverPredicate& shouldRemoveMarker);
     void repaintMarkers(DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
     void invalidateRenderedRectsForMarkersInRect(const LayoutRect&);
     void shiftMarkers(Node*, unsigned startOffset, int delta);
     void setMarkersActive(Range*, bool);
     void setMarkersActive(Node*, unsigned startOffset, unsigned endOffset, bool);
 
     DocumentMarker* markerContainingPoint(const LayoutPoint&, DocumentMarker::MarkerType);
     DocumentMarkerVector markersFor(Node*, DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
     DocumentMarkerVector markersInRange(Range*, DocumentMarker::MarkerTypes);
     DocumentMarkerVector markers();
     Vector<IntRect> renderedRectsForMarkers(DocumentMarker::MarkerType);
 
     void trace(Visitor*);
 
 #ifndef NDEBUG
     void showMarkers() const;
 #endif
 
 private:
     void addMarker(Node*, const DocumentMarker&);
 
     typedef WillBeHeapVector<OwnPtrWillBeMember<RenderedDocumentMarker> > MarkerList;
     typedef WillBeHeapVector<OwnPtrWillBeMember<MarkerList>, DocumentMarker::MarkerTypeIndexesCount> MarkerLists;
     typedef WillBeHeapHashMap<RawPtrWillBeWeakMember<const Node>, OwnPtrWillBeMember<MarkerLists> > MarkerMap;
+

[yosin_UTC9, 2014/08/11 01:01:59]

Accidental insertion of a blank line? 

[Klemen Forstnerič, 2014/08/11 16:24:49]

Whoops. Removed it.

     void mergeOverlapping(MarkerList*, DocumentMarker&);
     bool possiblyHasMarkers(DocumentMarker::MarkerTypes);
     void removeMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);
 
     MarkerMap m_markers;
     // Provide a quick way to determine whether a particular marker type is absent without going through the map.
     DocumentMarker::MarkerTypes m_possiblyExistingMarkerTypes;
 };
 
 } // namespace blink
 
 #ifndef NDEBUG
 void showDocumentMarkers(const blink::DocumentMarkerController*);
 #endif
 
 #endif // DocumentMarkerController_h