Adding a word to dictionary should remove spelling markers

Source/core/editing/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 806 matching lines @@
         m_frame.document()->markers().removeMarkers(DocumentMarker::Spelling);
     if (!isContinuousGrammarCheckingEnabled)
         m_frame.document()->markers().removeMarkers(DocumentMarker::Grammar);
 }
 
 void SpellChecker::removeSpellingMarkers()
 {
     m_frame.document()->markers().removeMarkers(DocumentMarker::MisspellingMarkers());
 }
 
+void SpellChecker::removeSpellingMarkersUnderWords(const Vector<String> &words)
+{

[groby-ooo-7-16, 2014/07/30 21:13:27]

You might want to test this for large documents. IIRC, whole-document checking
was definitely too slow. It might be that removal is fine, since it doesn't
involve any IPC, but it's worth trying out.

[Klemen Forstnerič, 2014/07/31 17:14:00]

Could you point out which piece of code was shown to be the bottleneck?

[groby-ooo-7-16, 2014/08/01 00:13:22]

The bottleneck for checking was the IPC traffic. You don't have that here, but
you still traverse the entire document. I honestly have no idea how much impact
that has - I'd try something like taking a giant text in a non-english language
(Proust comes to mind :), pasting it into the text field, adding one word to the
dictionary, and just checking if there's perceptible lag.

I'm not super-worried - it'll likely be fine - but it's worth checking.

[Klemen Forstnerič, 2014/08/01 21:58:17]

Seems to work fast enough. :-)

+    auto document = m_frame.document();
+    auto& markerController = document->markers();
+
+    auto markerNodePairs = markerController.markerNodePairs();
+    for (const auto &markerNodePair: markerNodePairs) {
+        auto node = const_cast<Node *>(markerNodePair.first.get());
+        auto marker = markerNodePair.second;
+
+        auto markerRange = Range::create(*document,
+            node, marker->startOffset(),
+            node, marker->endOffset());
+
+        if (words.contains(markerRange->text()))
+            markerController.removeMarkers(markerRange.get());
+    }
+
+    markerController.repaintMarkers();
+}
+
 void SpellChecker::spellCheckAfterBlur()
 {
     if (!m_frame.selection().selection().isContentEditable())
         return;
 
     if (isSelectionInTextField(m_frame.selection().selection())) {
         // textFieldDidEndEditing() and textFieldDidBeginEditing() handle this.
         return;
     }
 
@@ skipping 81 matching lines @@
 }
 
 void SpellChecker::requestTextChecking(const Element& element)
 {
     RefPtrWillBeRawPtr<Range> rangeToCheck = rangeOfContents(const_cast<Element*>(&element));
     m_spellCheckRequester->requestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling | TextCheckingTypeGrammar, TextCheckingProcessBatch, rangeToCheck, rangeToCheck));
 }
 
 
 } // namespace blink