Adding a word to dictionary should remove spelling markers

Source/core/dom/DocumentMarkerController.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 399 matching lines @@
         for (size_t markerListIndex = 0; markerListIndex < DocumentMarker::MarkerTypeIndexesCount; ++markerListIndex) {
             OwnPtrWillBeMember<MarkerList>& list = (*markers)[markerListIndex];
             for (size_t j = 0; list.get() && j < list->size(); ++j)
                 result.append(list->at(j).get());
         }
     }
     std::sort(result.begin(), result.end(), compareByStart);
     return result;
 }
 
+DocumentMarkerAndNodeVector DocumentMarkerController::markerNodePairs()

[groby-ooo-7-16, 2014/07/30 21:13:27]

This seems to copy a lot of data, depending on the amount of markers. Why not a
removeMarker that takes a predicate instead?

[Klemen Forstnerič, 2014/07/31 17:14:00]

That seems like a great idea, I'll add a removeMarkers method with a predicate.

[groby-ooo-7-16, 2014/08/01 00:13:22]

Acknowledged.

[Klemen Forstnerič, 2014/08/01 21:58:17]

Done.

+{
+    DocumentMarkerAndNodeVector result;
+    for (MarkerMap::iterator i = m_markers.begin(); i != m_markers.end(); ++i) {
+        MarkerLists* markers = i->value.get();
+        for (size_t markerListIndex = 0; markerListIndex < DocumentMarker::MarkerTypeIndexesCount; ++markerListIndex) {
+            OwnPtrWillBeMember<MarkerList>& list = (*markers)[markerListIndex];
+            for (size_t j = 0; list.get() && j < list->size(); ++j)
+                result.append(std::make_pair(i->key, list->at(j).get()));
+        }
+    }
+    return result;
+}
+
 DocumentMarkerVector DocumentMarkerController::markersInRange(Range* range, DocumentMarker::MarkerTypes markerTypes)
 {
     if (!possiblyHasMarkers(markerTypes))
         return DocumentMarkerVector();
 
     DocumentMarkerVector foundMarkers;
 
     Node* startContainer = range->startContainer();
     ASSERT(startContainer);
     Node* endContainer = range->endContainer();
@@ skipping 299 matching lines @@
 
 } // namespace blink
 
 #ifndef NDEBUG
 void showDocumentMarkers(const blink::DocumentMarkerController* controller)
 {
     if (controller)
         controller->showMarkers();
 }
 #endif