Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 419533003: Make HandleCloserAgent walk in 4x multiples on x64 (Closed)

Created:
6 years, 5 months ago by jschuh
Modified:
6 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Make HandleCloserAgent walk in 4x multiples on x64 Unfortunately, there's no non-flakey way to test this, because we can't control handle allocation. BUG=397130 R=wfh@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285397

Patch Set 1 : nit #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sandbox/win/src/handle_closer_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_closer_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jschuh
ptal
6 years, 5 months ago (2014-07-24 15:42:57 UTC) #1
Will Harris
LGTM
6 years, 5 months ago (2014-07-24 15:44:55 UTC) #2
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 15:45:41 UTC) #3
jschuh
The CQ bit was unchecked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 15:46:12 UTC) #4
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 15:49:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/419533003/40001
6 years, 5 months ago (2014-07-24 15:54:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:28:56 UTC) #7
jschuh
The CQ bit was unchecked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 22:44:00 UTC) #8
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 22:44:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/419533003/40001
6 years, 5 months ago (2014-07-24 22:47:00 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 22:55:49 UTC) #11
Message was sent while issue was closed.
Change committed as 285397

Powered by Google App Engine
This is Rietveld 408576698