Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/utility/shell_handler_win.cc

Issue 419523006: Experimentally isolate GetOpenFileName in a utility process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/shell_handler_win.h ('k') | ui/base/win/open_file_name_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/shell_handler_win.cc
diff --git a/chrome/utility/shell_handler_win.cc b/chrome/utility/shell_handler_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2f413c0fe813a79e231f38c15cedd0b955b443f5
--- /dev/null
+++ b/chrome/utility/shell_handler_win.cc
@@ -0,0 +1,51 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/utility/shell_handler_win.h"
+
+#include <commdlg.h>
+
+#include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/common/chrome_utility_messages.h"
+#include "content/public/utility/utility_thread.h"
+#include "ui/base/win/open_file_name_win.h"
+
+ShellHandler::ShellHandler() {}
+ShellHandler::~ShellHandler() {}
+
+bool ShellHandler::OnMessageReceived(const IPC::Message& message) {
+ bool handled = true;
+ IPC_BEGIN_MESSAGE_MAP(ShellHandler, message)
+ IPC_MESSAGE_HANDLER(ChromeUtilityMsg_GetOpenFileName,
+ OnGetOpenFileName)
+ IPC_MESSAGE_UNHANDLED(handled = false)
+ IPC_END_MESSAGE_MAP()
+ return handled;
+}
+
+void ShellHandler::OnGetOpenFileName(
+ HWND owner,
+ DWORD flags,
+ const GetOpenFileNameFilter& filter,
+ const base::FilePath& initial_directory,
+ const base::FilePath& filename) {
+ ui::win::OpenFileName open_file_name(owner, flags);
+ open_file_name.SetInitialSelection(initial_directory, filename);
+ open_file_name.SetFilters(filter);
+
+ base::FilePath directory;
+ std::vector<base::FilePath> filenames;
+
+ if (::GetOpenFileName(open_file_name.GetOPENFILENAME()))
+ open_file_name.GetResult(&directory, &filenames);
+
+ if (filenames.size()) {
+ content::UtilityThread::Get()->Send(
+ new ChromeUtilityHostMsg_GetOpenFileName_Result(directory, filenames));
+ } else {
+ content::UtilityThread::Get()->Send(
+ new ChromeUtilityHostMsg_GetOpenFileName_Failed());
+ }
+}
« no previous file with comments | « chrome/utility/shell_handler_win.h ('k') | ui/base/win/open_file_name_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698