Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: chrome/browser/chrome_select_file_dialog_factory_win.h

Issue 419523006: Experimentally isolate GetOpenFileName in a utility process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_select_file_dialog_factory_win.h
diff --git a/chrome/browser/chrome_select_file_dialog_factory_win.h b/chrome/browser/chrome_select_file_dialog_factory_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..70b320f1abf3cf6b35a1a299110280d35a34017f
--- /dev/null
+++ b/chrome/browser/chrome_select_file_dialog_factory_win.h
@@ -0,0 +1,39 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROME_SELECT_FILE_DIALOG_FACTORY_WIN_H_
+#define CHROME_BROWSER_CHROME_SELECT_FILE_DIALOG_FACTORY_WIN_H_
+
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "ui/shell_dialogs/select_file_dialog_factory.h"
+
+namespace base {
+class SequencedTaskRunner;
+} // namespace base
+
+// Implements a Select File dialog that delegates to a Metro file picker on
+// Metro and to a utility process otherwise. The utility process is used in
+// order to isolate the Chrome browser process from potential instability
+// caused by Shell extension modules loaded by GetOpenFileName.
+class ChromeSelectFileDialogFactory : public ui::SelectFileDialogFactory {
+ public:
sky 2014/07/31 20:47:46 nit: spacing is off.
erikwright (departed) 2014/08/01 13:53:15 Done.
+ // Uses |blocking_task_runner| to perform IPC with the utility process.
+ explicit ChromeSelectFileDialogFactory(
+ const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);
+ virtual ~ChromeSelectFileDialogFactory();
+
+ // ui::SelectFileDialogFactory implementation
+ virtual ui::SelectFileDialog* Create(
+ ui::SelectFileDialog::Listener* listener,
+ ui::SelectFilePolicy* policy) OVERRIDE;
+
+ private:
+ scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeSelectFileDialogFactory);
+};
+
+#endif // CHROME_BROWSER_CHROME_SELECT_FILE_DIALOG_FACTORY_WIN_H_

Powered by Google App Engine
This is Rietveld 408576698