Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 419523004: IDL: Partial revert of r178934 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 4e5eed4988e95acdb2d0073c444d2cdac3486994..5033ad4fd1b99449b4b992572f92ba912b8ac755 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -573,7 +573,7 @@ static void {{name}}(const v8::FunctionCallbackInfo<v8::Value>& info)
{% endif %}
{# Overloaded constructors have length checked during overload resolution #}
{% if constructor.number_of_required_arguments and not constructor.overload_index %}
- if (info.Length() < {{constructor.number_of_required_arguments}}) {
+ if (UNLIKELY(info.Length() < {{constructor.number_of_required_arguments}})) {
{{throw_minimum_arity_type_error(constructor, constructor.number_of_required_arguments)}};
return;
}
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698