Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 419503004: Kill block format. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
dtu, chrishenry, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -108 lines) Patch
D tools/telemetry/telemetry/results/block_page_measurement_results.py View 1 1 chunk +0 lines, -36 lines 0 comments Download
D tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py View 1 1 chunk +0 lines, -65 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
nednguyen
6 years, 4 months ago (2014-07-24 15:30:17 UTC) #1
tonyg
lgtm Let's see if anyone notices and complains
6 years, 4 months ago (2014-07-24 15:40:06 UTC) #2
chrishenry
lgtm, but can you block this on https://codereview.chromium.org/394953002/, just in case this change needs to ...
6 years, 4 months ago (2014-07-24 15:41:23 UTC) #3
nednguyen
On 2014/07/24 15:41:23, chrishenry wrote: > lgtm, but can you block this on > https://codereview.chromium.org/394953002/, ...
6 years, 4 months ago (2014-07-24 15:43:07 UTC) #4
dtu
lgtm
6 years, 4 months ago (2014-07-24 23:40:23 UTC) #5
chrishenry
lgtm, that other patch is in btw. Feel free to submit.
6 years, 4 months ago (2014-07-25 23:01:16 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-07-25 23:02:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/419503004/1
6 years, 4 months ago (2014-07-25 23:03:35 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 4 months ago (2014-07-25 23:07:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-25 23:10:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/30594) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/32510)
6 years, 4 months ago (2014-07-25 23:10:04 UTC) #11
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-07-25 23:15:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/419503004/20001
6 years, 4 months ago (2014-07-25 23:16:46 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-26 18:03:38 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-07-26 19:48:50 UTC) #15
Message was sent while issue was closed.
Change committed as 285793

Powered by Google App Engine
This is Rietveld 408576698