Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 419503002: Flag for serialization when compiling code stubs if --serialize-toplevel. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Flag for serialization when compiling code stubs if --serialize-toplevel. R=mvstanton@chromium.org BUG=v8:3465 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22596

Patch Set 1 #

Patch Set 2 : change test case slightly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M src/code-stubs.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-24 11:50:33 UTC) #1
mvstanton
Great to have that multi-isolate test! LGTM.
6 years, 5 months ago (2014-07-24 12:04:22 UTC) #2
Yang
6 years, 5 months ago (2014-07-24 12:11:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22596 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698