Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419493002: Don't set use_custom_libcxx in ASan builds on CrOS. (Closed)

Created:
6 years, 5 months ago by Alexander Potapenko
Modified:
6 years, 5 months ago
Reviewers:
earthdok
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Don't set use_custom_libcxx in ASan builds on CrOS. BUG=396979 R=earthdok@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
PTAL
6 years, 5 months ago (2014-07-24 11:23:59 UTC) #1
earthdok
lgtm
6 years, 5 months ago (2014-07-24 11:34:53 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 5 months ago (2014-07-24 11:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/419493002/1
6 years, 5 months ago (2014-07-24 11:37:22 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 15:41:56 UTC) #5
Message was sent while issue was closed. 
Change committed as 285282

Powered by Google App Engine
This is Rietveld 408576698