Increased delay before next portal detection attempt in the case of !ONLINE -> ONLINE transition.

Increased delay before next portal detection attempt in the case of !ONLINE -> ONLINE transition.

BUG=377725
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285328

[Denis Kuznetsov (DE-MUC), 2014-07-24 11:29:46]

lgtm with comments

https://chromiumcodereview.appspot.com/419463004/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/net/network_portal_detector_impl.cc (right):

https://chromiumcodereview.appspot.com/419463004/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/net/network_portal_detector_impl.cc:41: // transition.
Long/Short, use ! instead of ~ for negation.

[Nikita (slow), 2014-07-24 12:31:22]

Please update CL description and specify exact values in seconds for periodic
captive portal check when current state is online.

[Nikita (slow), 2014-07-24 12:34:07]

I also suggest adding comment in the source file in addition to these constants
because it is hard to follow login in whole file if you want just to know:

OFFLINE/CP state
timeout between attempts
each attempt timeout

back off logic?

ONLINE state
timeout between periodic checks

[Nikita (slow), 2014-07-24 12:34:41]

On 2014/07/24 12:34:07, Nikita Kostylev wrote:
> I also suggest adding comment in the source file in addition to these
constants
> because it is hard to follow login in whole file if you want just to know:

correction: it's hard to follow logic

[ygorshenin1, 2014-07-24 13:08:01]

On 2014/07/24 12:34:07, Nikita Kostylev wrote:
> I also suggest adding comment in the source file in addition to these
constants
> because it is hard to follow login in whole file if you want just to know:
> 
> OFFLINE/CP state
> timeout between attempts
> each attempt timeout
> 
> back off logic?
> 
> ONLINE state
> timeout between periodic checks

Which source file do you mean? It's not good to add such comments to
network_portal_detector_impl.cc just because implementation of portal detector
strategy could change. Also it's redundant to add such comments to
network_portal_detector_strategy.cc, as backoff_entry.h is well-documented.
WDYT?

[ygorshenin1, 2014-07-24 14:26:03]

Nikita, could you please take another look?

[Nikita (slow), 2014-07-24 15:29:36]

lgtm

[ygorshenin1, 2014-07-24 15:40:02]

The CQ bit was checked by ygorshenin@chromium.org

[ygorshenin1, 2014-07-24 15:40:11]

Many thanks!

[commit-bot: I haz the power, 2014-07-24 15:43:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/419463004/60001

[commit-bot: I haz the power, 2014-07-24 18:11:24]

Change committed as 285328