src/x64/assembler-x64.h - Issue 419343003: when open macro GENERATED_CODE_COVERAGE, fix compiler error and fd leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.h

Issue 419343003: when open macro GENERATED_CODE_COVERAGE, fix compiler error and fd leak (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.h

diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h

index 4259e9b50ef5ccbfd5d5b8f2452b6052697a5543..5801970bbdfcb773b2cf1e614d7aff757cf7b0d3 100644

--- a/src/x64/assembler-x64.h

+++ b/src/x64/assembler-x64.h

@@ -500,7 +500,7 @@ class Assembler : public AssemblerBase {

// is too small, a fatal error occurs. No deallocation of the buffer is done

// upon destruction of the assembler.

Assembler(Isolate* isolate, void* buffer, int buffer_size);

- virtual ~Assembler() { }

+ virtual ~Assembler();

// GetCode emits any pending (non-emitted) code and fills the descriptor

// desc. GetCode() is idempotent; it returns the same result if no other

« no previous file with comments | « src/mips64/simulator-mips64.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »