IME refactoring: ChromeOS introduce input methods State.

chromeos/ime/component_extension_ime_manager.cc

Index: chromeos/ime/component_extension_ime_manager.cc
diff --git a/chromeos/ime/component_extension_ime_manager.cc b/chromeos/ime/component_extension_ime_manager.cc
index f77421918c29bff0346364840cd9875e36069574..d3d917b6ae515f8408d485675bf524827a542e11 100644
--- a/chromeos/ime/component_extension_ime_manager.cc
+++ b/chromeos/ime/component_extension_ime_manager.cc
@@ -212,6 +212,9 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
     const std::string& input_method_id,
     ComponentExtensionIME* out_extension,
     ComponentExtensionEngine* out_engine) {
+  //  LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+  //     << input_method_id << "', out_extension=" << out_extension
+  //     << ", out_engine=" << out_engine << "): Called.";

[Shu Chen, 2014/08/07 15:40:19]

pls clean up all the logs.

[Alexander Alekseev, 2014/08/13 10:14:15]

Done.

   if (!extension_ime_util::IsComponentExtensionIME(input_method_id))
     return false;
   for (size_t i = 0; i < component_extension_imes_.size(); ++i) {
@@ -219,10 +222,20 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
     const std::vector<ComponentExtensionEngine>& engines =
         component_extension_imes_[i].engines;
 
+    //    LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+    //       << input_method_id << "', out_extension=" << out_extension
+    //       << ", out_engine=" << out_engine << "): checking extension IME
+    //       number " << i << " .";
     for (size_t j = 0; j < engines.size(); ++j) {
       const std::string trial_ime_id =
           extension_ime_util::GetComponentInputMethodID(
               extension_id, engines[j].engine_id);
+      //      LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+      //         << input_method_id << "', out_extension=" << out_extension
+      //         << ", out_engine=" << out_engine << "): checking engine name='"
+      //         << engines[j].display_name << "' trial_ime_id='" <<
+      //         trial_ime_id << "'.";
+
       if (trial_ime_id != input_method_id)
         continue;
 
@@ -230,9 +243,15 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
         *out_extension = component_extension_imes_[i];
       if (out_engine)
         *out_engine = component_extension_imes_[i].engines[j];
+      //      LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+      //         << input_method_id << "', out_extension=" << out_extension
+      //         << ", out_engine=" << out_engine << "): Result is True.";
       return true;
     }
   }
+  //  LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+  //     << input_method_id << "', out_extension=" << out_extension
+  //     << ", out_engine=" << out_engine << "): Result is False.";
   return false;
 }