Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chromeos/ime/component_extension_ime_manager.h

Issue 419293002: IME refactoring: ChromeOS introduce input methods State. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit test fixed. Re-sorted methods of StateImpl and IMM. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/component_extension_ime_manager.h
diff --git a/chromeos/ime/component_extension_ime_manager.h b/chromeos/ime/component_extension_ime_manager.h
index ee00fb2ce2a5e9fcc61e2f77e0dcd623200233f3..a505332b330929b95fba2863ec1e7931b54006b4 100644
--- a/chromeos/ime/component_extension_ime_manager.h
+++ b/chromeos/ime/component_extension_ime_manager.h
@@ -14,6 +14,8 @@
#include "chromeos/chromeos_export.h"
#include "chromeos/ime/input_method_descriptor.h"
+class Profile;
+
namespace chromeos {
// Represents an engine in component extension IME.
@@ -52,12 +54,14 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManagerDelegate {
// Loads component extension IME associated with |extension_id|.
// Returns false if it fails, otherwise returns true.
- virtual bool Load(const std::string& extension_id,
+ virtual bool Load(Profile* profile,
+ const std::string& extension_id,
const std::string& manifest,
const base::FilePath& path) = 0;
// Unloads component extension IME associated with |extension_id|.
- virtual void Unload(const std::string& extension_id,
+ virtual void Unload(Profile* profile,
+ const std::string& extension_id,
const base::FilePath& path) = 0;
};
@@ -75,12 +79,14 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManager {
// Loads |input_method_id| component extension IME. This function returns true
// on success. This function is safe to call multiple times. Returns false if
// already corresponding component extension is loaded.
- bool LoadComponentExtensionIME(const std::string& input_method_id);
+ bool LoadComponentExtensionIME(Profile* profile,
+ const std::string& input_method_id);
// Unloads |input_method_id| component extension IME. This function returns
// true on success. This function is safe to call multiple times. Returns
// false if already corresponding component extension is unloaded.
- bool UnloadComponentExtensionIME(const std::string& input_method_id);
+ bool UnloadComponentExtensionIME(Profile* profile,
+ const std::string& input_method_id);
// Returns true if |input_method_id| is whitelisted component extension input
// method.

Powered by Google App Engine
This is Rietveld 408576698