chromeos/ime/component_extension_ime_manager_unittest.cc - Issue 419293002: IME refactoring: ChromeOS introduce input methods State.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/ime/component_extension_ime_manager_unittest.cc

Issue 419293002: IME refactoring: ChromeOS introduce input methods State. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('K') | « chromeos/ime/component_extension_ime_manager.cc ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/ime/component_extension_ime_manager_unittest.cc

diff --git a/chromeos/ime/component_extension_ime_manager_unittest.cc b/chromeos/ime/component_extension_ime_manager_unittest.cc

index 4da6fa32d8d531f3a0363df075129e2e4392b365..9e8bdb3c19875d50f761af957f79c22813c1d6fd 100644

--- a/chromeos/ime/component_extension_ime_manager_unittest.cc

+++ b/chromeos/ime/component_extension_ime_manager_unittest.cc

@@ -136,7 +136,8 @@ TEST_F(ComponentExtensionIMEManagerTest, LoadComponentExtensionIMETest) {

extension_ime_util::GetComponentInputMethodID(

ime_list_[i].id,

ime_list_[i].engines[j].engine_id);

- component_ext_mgr_->LoadComponentExtensionIME(input_method_id);

+ component_ext_mgr_->LoadComponentExtensionIME(NULL /* profile */,

+ input_method_id);

EXPECT_EQ(ime_list_[i].id, mock_delegate_->last_loaded_extension_id());

}

@@ -150,7 +151,8 @@ TEST_F(ComponentExtensionIMEManagerTest, UnloadComponentExtensionIMETest) {

extension_ime_util::GetComponentInputMethodID(

ime_list_[i].id,

ime_list_[i].engines[j].engine_id);

- component_ext_mgr_->UnloadComponentExtensionIME(input_method_id);

+ component_ext_mgr_->UnloadComponentExtensionIME(NULL /* profile */,

+ input_method_id);

EXPECT_EQ(ime_list_[i].id, mock_delegate_->last_unloaded_extension_id());

}