Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 419253002: Use WebBlendMode in FEBlend (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Use WebBlendMode in FEBlend This replaces the BlendModeType enumeration with the WebBlendMode for FEBlend::m_mode. The former is moved to SVGFEBlendElement. This enables FEBlend to use all of the blend modes available in WebBlendMode, and leave any subset selection to the client of FEBlend (which is SVGFEBlendElement). The BlendModeType->string mapping is replaced by compositeOperatorName(). BUG=389594 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179029

Patch Set 1 #

Patch Set 2 : Fiddle with BlendModeType enum. #

Patch Set 3 : WebBlendModeNormal -> "normal" (not "source-over"). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -96 lines) Patch
M Source/core/svg/SVGFEBlendElement.h View 1 2 chunks +13 lines, -5 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 1 4 chunks +29 lines, -9 lines 0 comments Download
M Source/platform/graphics/cpu/arm/filters/FEBlendNEON.h View 1 chunk +5 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.h View 2 chunks +6 lines, -14 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.cpp View 1 2 4 chunks +33 lines, -61 lines 0 comments Download
M Source/platform/graphics/filters/ImageFilterBuilderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
fs
6 years, 5 months ago (2014-07-25 16:50:25 UTC) #1
Stephen White
LGTM
6 years, 5 months ago (2014-07-25 17:00:43 UTC) #2
Rik
On 2014/07/25 16:50:25, fs wrote: Do you have plans to implement the full set of ...
6 years, 5 months ago (2014-07-25 17:40:44 UTC) #3
fs
On 2014/07/25 17:40:44, Rik wrote: > On 2014/07/25 16:50:25, fs wrote: > > Do you ...
6 years, 4 months ago (2014-07-28 08:11:07 UTC) #4
fs
The CQ bit was checked by fs@opera.com
6 years, 4 months ago (2014-07-28 08:11:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/419253002/20001
6 years, 4 months ago (2014-07-28 08:12:38 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 08:49:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 09:52:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19189)
6 years, 4 months ago (2014-07-28 09:52:32 UTC) #9
fs
The CQ bit was checked by fs@opera.com
6 years, 4 months ago (2014-07-28 12:10:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/419253002/40001
6 years, 4 months ago (2014-07-28 12:10:42 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 12:14:00 UTC) #12
Message was sent while issue was closed.
Change committed as 179029

Powered by Google App Engine
This is Rietveld 408576698