Issue 41923004: Factor out skia_keep_frame_pointer. Handy with perf to get call stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41923004: Factor out skia_keep_frame_pointer. Handy with perf to get call stacks. (Closed)

Created:
7 years, 1 month ago by mtklein

Modified:
7 years, 1 month ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Factor out skia_keep_frame_pointer. Handy with perf to get call stacks. Today it's set when we're running a sanitizer, but it's more generally useful. perf record -g (--call-graph) only works for me if we don't omit the frame pointer. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11966

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	gyp/common_conditions.gypi	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	gyp/common_variables.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/41923004/1

7 years, 1 month ago (2013-10-25 17:52:13 UTC) #3

Message was sent while issue was closed.

Change committed as 11966

Expand Messages | Collapse Messages