Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 419213003: Move PolicyCertVerifier test back to browser_tests. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move PolicyCertVerifier test back to browser_tests. Partially reverts crrev.com/284112 by moving the verifier test from unit_tests target back to browser_tests, because of trust information leaking between test cases. BUG=396497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -236 lines) Patch
A + chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/chromeos/policy/policy_cert_verifier_unittest.cc View 1 chunk +0 lines, -236 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pneubeck (no reviews)
6 years, 5 months ago (2014-07-25 10:02:24 UTC) #1
Joao da Silva
lgtm Thanks!
6 years, 5 months ago (2014-07-25 13:12:26 UTC) #2
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-25 13:30:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/419213003/1
6 years, 5 months ago (2014-07-25 13:31:46 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 14:54:38 UTC) #5
Message was sent while issue was closed.
Change committed as 285589

Powered by Google App Engine
This is Rietveld 408576698