Issue 419213002: [Not for review] Implement a <blink> tag in Blink-in-JS

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[Not for review] Implement a <blink> tag in Blink-in-JS "Blink-in-JS" literally :) (Note: I'm not intending to land this CL.)

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -0 lines)			Patch
M	Source/core/BUILD.gn	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/core_generated.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/html.css	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLBlinkElement.h	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLBlinkElement.cpp	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLBlinkElement.idl	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	Source/core/html/HTMLBlinkElement.js	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTagNames.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/parser/HTMLElementStack.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/parser/HTMLStackItem.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/parser/HTMLTreeBuilder.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/419213002/diff/40001/Source/core/html/HTMLBlinkElement.js File Source/core/html/HTMLBlinkElement.js (right): https://codereview.chromium.org/419213002/diff/40001/Source/core/html/HTMLBlinkElement.js#newcode11 Source/core/html/HTMLBlinkElement.js:11: this.setAttribute("style", this.displayed_ ? "display:inline" : "display:none"); I think you're ...

6 years, 4 months ago (2014-08-01 21:42:45 UTC) #1

haraken

6 years, 4 months ago (2014-08-01 21:48:03 UTC) #2

https://codereview.chromium.org/419213002/diff/40001/Source/core/html/HTMLBli...
File Source/core/html/HTMLBlinkElement.js (right):

https://codereview.chromium.org/419213002/diff/40001/Source/core/html/HTMLBli...
Source/core/html/HTMLBlinkElement.js:11: this.setAttribute("style",
this.displayed_ ? "display:inline" : "display:none");
On 2014/08/01 21:42:45, abarth wrote:
> I think you're supposed to twiddle between visibility:visible and
> visibility:hidden.  :)

Done.

Expand Messages | Collapse Messages