Source/web/WebSharedWorkerImpl.h - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSharedWorkerImpl.h

diff --git a/Source/web/WebSharedWorkerImpl.h b/Source/web/WebSharedWorkerImpl.h

index 0ed732379c3d3393eb3f2a24521d408c55408bf4..84cbdbb336471f63ec197018d29d9f5777f32b5a 100644

--- a/Source/web/WebSharedWorkerImpl.h

+++ b/Source/web/WebSharedWorkerImpl.h

@@ -34,6 +34,7 @@

#include "public/web/WebSharedWorker.h"

#include "core/dom/ExecutionContext.h"

+#include "core/inspector/ConsoleMessage.h"

vsevik 2014/08/08 13:06:29 ditto

kozyatinskiy1 2014/08/08 14:58:09 Done.

#include "core/workers/WorkerLoaderProxy.h"

#include "core/workers/WorkerReportingProxy.h"

#include "core/workers/WorkerScriptLoaderClient.h"

@@ -75,9 +76,7 @@ public:

// blink::WorkerReportingProxy methods:

virtual void reportException(

const WTF::String&, int, int, const WTF::String&) OVERRIDE;

- virtual void reportConsoleMessage(

- blink::MessageSource, blink::MessageLevel,

- const WTF::String&, int, const WTF::String&) OVERRIDE;

+ virtual void reportConsoleMessage(PassRefPtr<blink::ConsoleMessage>) OVERRIDE;

virtual void postMessageToPageInspector(const WTF::String&) OVERRIDE;

virtual void updateInspectorStateCookie(const WTF::String&) OVERRIDE;

virtual void workerGlobalScopeStarted(blink::WorkerGlobalScope*) OVERRIDE;

« Source/web/ServiceWorkerGlobalScopeProxy.h ('K') | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »