Source/modules/websockets/DOMWebSocket.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/DOMWebSocket.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerReportingProxy.h ('K') | « Source/modules/webdatabase/DatabaseManager.cpp ('k') | Source/modules/websockets/MainThreadWebSocketChannel.cpp » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/DOMWebSocket.cpp

diff --git a/Source/modules/websockets/DOMWebSocket.cpp b/Source/modules/websockets/DOMWebSocket.cpp

index 1c8f06e7843cdb9e6efff82e98237d3e1913e7f8..7911f1d17c69f72a3dda0374b1cfeae7d83c70e3 100644

--- a/Source/modules/websockets/DOMWebSocket.cpp

+++ b/Source/modules/websockets/DOMWebSocket.cpp

@@ -43,6 +43,7 @@

#include "core/frame/LocalDOMWindow.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/csp/ContentSecurityPolicy.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/ScriptCallStack.h"

#include "modules/websockets/CloseEvent.h"

#include "platform/Logging.h"

@@ -246,7 +247,7 @@ DOMWebSocket::~DOMWebSocket()

void DOMWebSocket::logError(const String& message)

{

- executionContext()->addConsoleMessage(JSMessageSource, ErrorMessageLevel, message);

+ executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));

}

PassRefPtrWillBeRawPtr<DOMWebSocket> DOMWebSocket::create(ExecutionContext* context, const String& url, ExceptionState& exceptionState)