Source/core/workers/WorkerObjectProxy.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerObjectProxy.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerObjectProxy.h ('K') | « Source/core/workers/WorkerObjectProxy.h ('k') | Source/core/workers/WorkerReportingProxy.h » ('j') | Source/core/workers/WorkerReportingProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerObjectProxy.cpp

diff --git a/Source/core/workers/WorkerObjectProxy.cpp b/Source/core/workers/WorkerObjectProxy.cpp

index 3c9abc4877993d8ec99c02ad99a1920d019e71f0..18143ca7d1ba556217041490260f57cfc3e4adde 100644

--- a/Source/core/workers/WorkerObjectProxy.cpp

+++ b/Source/core/workers/WorkerObjectProxy.cpp

@@ -71,9 +71,9 @@ void WorkerObjectProxy::reportException(const String& errorMessage, int lineNumb

m_executionContext->postTask(createCrossThreadTask(&WorkerMessagingProxy::reportException, m_messagingProxy, errorMessage, lineNumber, columnNumber, sourceURL));

}

-void WorkerObjectProxy::reportConsoleMessage(MessageSource source, MessageLevel level, const String& message, int lineNumber, const String& sourceURL)

+void WorkerObjectProxy::reportConsoleMessage(PassRefPtr<ConsoleMessage> consoleMessage)

{

- m_executionContext->postTask(createCrossThreadTask(&WorkerMessagingProxy::reportConsoleMessage, m_messagingProxy, source, level, message, lineNumber, sourceURL));

+ m_executionContext->postTask(createCrossThreadTask(&WorkerMessagingProxy::reportConsoleMessage, m_messagingProxy, consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber(), consoleMessage->url()));

}

void WorkerObjectProxy::postMessageToPageInspector(const String& message)