Source/core/loader/DocumentLoader.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentLoader.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/html/parser/XSSAuditorDelegate.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/DocumentLoader.cpp

diff --git a/Source/core/loader/DocumentLoader.cpp b/Source/core/loader/DocumentLoader.cpp

index 6d5700eb8f56b6e25507a13c7613603e605525c0..0f96486bfd854ce4ca0dae64fda0c88f653947dd 100644

--- a/Source/core/loader/DocumentLoader.cpp

+++ b/Source/core/loader/DocumentLoader.cpp

@@ -50,6 +50,7 @@

#include "core/page/FrameTree.h"

#include "core/page/Page.h"

#include "core/frame/Settings.h"

+#include "core/inspector/ConsoleMessage.h"

#include "platform/Logging.h"

#include "platform/UserGestureIndicator.h"

#include "platform/mhtml/ArchiveResource.h"

@@ -455,7 +456,9 @@ void DocumentLoader::responseReceived(Resource* resource, const ResourceResponse

if (frameLoader()->shouldInterruptLoadForXFrameOptions(content, response.url(), identifier)) {

InspectorInstrumentation::continueAfterXFrameOptionsDenied(m_frame, this, identifier, response);

String message = "Refused to display '" + response.url().elidedString() + "' in a frame because it set 'X-Frame-Options' to '" + content + "'.";

- frame()->document()->addConsoleMessageWithRequestIdentifier(SecurityMessageSource, ErrorMessageLevel, message, identifier);

+ RefPtr<ConsoleMessage> consoleMessage = ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, message);

+ consoleMessage->setRequestIdentifier(identifier);

+ frame()->document()->addMessage(consoleMessage.release());

frame()->document()->enforceSandboxFlags(SandboxOrigin);

if (FrameOwner* owner = frame()->owner())

owner->dispatchLoad();