Source/core/html/canvas/WebGLRenderingContextBase.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/csp/CSPDirectiveList.cpp ('K') | « Source/core/html/HTMLShadowElement.cpp ('k') | Source/core/html/parser/XSSAuditor.cpp » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.cpp

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.cpp b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

index 58d0103ba251f81066af58ea90fd373645e50232..aafff6f5c3f2ee65d0162a8cfe8abf8ecfdbef30 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.cpp

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

@@ -70,6 +70,7 @@

#include "core/html/canvas/WebGLSharedWebGraphicsContext3D.h"

#include "core/html/canvas/WebGLTexture.h"

#include "core/html/canvas/WebGLUniformLocation.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/loader/FrameLoader.h"

#include "core/loader/FrameLoaderClient.h"

@@ -5110,7 +5111,7 @@ void WebGLRenderingContextBase::printWarningToConsole(const String& message)

{

if (!canvas())

return;

- canvas()->document().addConsoleMessage(RenderingMessageSource, WarningMessageLevel, message);

+ canvas()->document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, WarningMessageLevel, message));

}

bool WebGLRenderingContextBase::validateFramebufferFuncParameters(const char* functionName, GLenum target, GLenum attachment)