Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 419173002: Files.app: Make the sort for the search result stable. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, fukino
Project:
chromium
Visibility:
Public.

Description

Files.app: Make the sort for the search result stable. In search result, the entries have same names and it causes unstability of the sort. The CL let the compare function to see URL when the names are same. The CL also moves the sort functions from the UI class to the model class. BUG=397386 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285537

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -95 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 2 chunks +105 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_table.js View 3 chunks +0 lines, -90 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-25 02:36:40 UTC) #1
yoshiki
lgtm https://codereview.chromium.org/419173002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/419173002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode516 ui/file_manager/file_manager/foreground/js/directory_contents.js:516: * @type {FileList} FileListModel
6 years, 5 months ago (2014-07-25 06:37:35 UTC) #2
hirono
Thanks! https://codereview.chromium.org/419173002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/419173002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode516 ui/file_manager/file_manager/foreground/js/directory_contents.js:516: * @type {FileList} On 2014/07/25 06:37:35, yoshiki wrote: ...
6 years, 5 months ago (2014-07-25 07:44:14 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 07:44:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/419173002/20001
6 years, 5 months ago (2014-07-25 07:45:00 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:00:40 UTC) #6
Message was sent while issue was closed.
Change committed as 285537

Powered by Google App Engine
This is Rietveld 408576698