Issue 419163004: Add HandleScopes and ScriptForbiddenScope::AllowUserAgentScript to private scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419163004: Add HandleScopes and ScriptForbiddenScope::AllowUserAgentScript to private scripts (Closed)

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 5 months ago

Reviewers:
arv (Not doing code reviews), tasak, bashi

CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Add HandleScopes and ScriptForbiddenScope::AllowUserAgentScript to private scripts This is a split CL from https://codereview.chromium.org/394773003/. - Added HandleScopes because some caller sites don't have HandleScopes. - Added AllowUserAgentScript because we need to allow script execution to execute private scripts (of course). BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178896

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -0 lines)			Patch
M	Source/bindings/scripts/v8_attributes.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/scripts/v8_methods.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/templates/attributes.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/bindings/templates/methods.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	17 chunks	+33 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/419163004/1

6 years, 5 months ago (2014-07-25 02:48:38 UTC) #4

Message was sent while issue was closed.

LGTM