Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419143002: Add DVLOGs of interesting RapporService events. (Closed)

Created:
6 years, 5 months ago by Steven Holte
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DVLOGs of interesting RapporService events. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285680

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M components/rappor/rappor_service.cc View 1 5 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Steven Holte
6 years, 5 months ago (2014-07-25 01:02:31 UTC) #1
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/419143002/diff/1/components/rappor/rappor_service.cc File components/rappor/rappor_service.cc (right): https://codereview.chromium.org/419143002/diff/1/components/rappor/rappor_service.cc#newcode67 components/rappor/rappor_service.cc:67: DVLOG(1) << "RapporService not started:" Nit: Add a ...
6 years, 5 months ago (2014-07-25 14:46:39 UTC) #2
Steven Holte
https://codereview.chromium.org/419143002/diff/1/components/rappor/rappor_service.cc File components/rappor/rappor_service.cc (right): https://codereview.chromium.org/419143002/diff/1/components/rappor/rappor_service.cc#newcode67 components/rappor/rappor_service.cc:67: DVLOG(1) << "RapporService not started:" On 2014/07/25 14:46:39, Alexei ...
6 years, 5 months ago (2014-07-25 19:16:48 UTC) #3
Steven Holte
The CQ bit was checked by holte@chromium.org
6 years, 5 months ago (2014-07-25 19:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/holte@chromium.org/419143002/20001
6 years, 5 months ago (2014-07-25 19:17:59 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 21:19:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 285680

Powered by Google App Engine
This is Rietveld 408576698